gleam-lang/gleam

Offer to attempt again with conflicting deps unlocked when version resolution fails

Open

#3,622 opened on Sep 15, 2024

View on GitHub
 (10 comments) (1 reaction) (0 assignees)Rust (21,417 stars) (960 forks)batch import
help wanted

Description

If you add a new dep it can fail due to conflicts with already locked versions of other deps.

I don't know how effective this might be, but I think we could do this:

  • When we have a version conflict
  • and some of the packages in the conflict chain are locked
  • unlock those packages and try again
$ gleam add wibble
  Resolving versions
# ... few seconds later, when the first attempt fails
  Expanding search range
# ... bit more waiting
      Added wibble v2.0.0
    Updated wubble v2.0.0 -> v2.2.5
    Updated blab v1.0.0 -> v1.5.0

note: Previously this suggested an interactive design, is has been simplified.

Contributor guide

Tech stack
rust
Domain
clitooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingDependency resolution concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the package resolution logic in the gleam codebase, likely in a module handling dependency resolution. Identify where version conflicts are detected and where locked packages are tracked. Implement logic to unlock locked packages in the conflict chain and retry the resolution. Test with scenarios where adding a new dep conflicts with existing locked versions.