gleam-lang/gleam

Import module in code action to fill missing case patterns

Open

#3,568 opened on Aug 27, 2024

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Rust (21,417 stars) (960 forks)batch import
help wanted

Description

Currently, if a user runs the "Add missing patterns" code action on this code:

case some_value.optional_field {}

They would get something like:

case some_value.optional_field {
  option.Some(_) -> todo
  option.None -> todo
}

Which is correct, but doesn't account for the fact that they need to import the gleam/option module. It would be helpful to detect this and automatically import gleam/option in this case.

Contributor guide

Tech stack
rust
Domain
developer experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustGleam compiler codebaseCode action internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Look at the existing code action for 'Add missing patterns' in the Gleam compiler. Search for the pattern matching completion logic in the compiler's code action module. Review comments in the issue for any maintainer guidance. Determine where in the generated code the import statement needs to be inserted. Possibly modify the compiler's code generation for pattern matches to include import statements when necessary.
Import module in code action to fill missing case patterns · gleam-lang/gleam#3568 | Good First Issue