gleam-lang/gleam

LSP: cleanup when a client has closed all files in a project

Open

#3,205 opened on May 27, 2024

View on GitHub
 (0 comments) (2 reactions) (0 assignees)Rust (21,417 stars) (960 forks)batch import
help wanted

Description

When the client has closed all files for a Gleam project:

  • Unset all the diagnostics for that project
  • Discard the engine for that project

Contributor guide

Tech stack
rust
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingLSP basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue describes two actions: unset diagnostics and discard engine for a project when all files are closed. To implement, examine the LSP handler in src/lsp/ or similar. Look at how diagnostics are set (likely via publishDiagnostics) and how the engine is stored per project. Ensure to handle the case where the client closes all files without opening any new ones. Check existing tests for similar cleanup logic.