gleam-lang/gleam

Raise error if building with an enforced target when previously building without enforcing and the target is not fully supported

Open

#2,594 opened on Feb 10, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (21,417 stars) (960 forks)batch import
help wanted

Description

If you run gleam run -m blah where blah is a module from a dependency it is possible for the root package to build even if it doesn't support the current target. This is so that you can run deps code that is for the other target.

This is good, but there's a problem in that when you run gleam build again normally it reports success as the modules are loaded from the cache, and this does not check target support even if it is supposed to be enforced. This could be confusing to someone as it seems their build works when it does not.

It is not possible however to get into a bad state here as gleam run and gleam publish will both check to make sure the target is supported. As such this is a very low priority item of work.

Contributor guide

Tech stack
rust
Domain
build systemdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustGleam build system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue involves the Gleam build cache and target enforcement. Look at the build command logic in the Gleam compiler source code, particularly the part that handles cached modules. The fix should check target support when building with enforcement, even if modules are cached. There are no linked PRs or comments.