glanceapp/glance

Commented out config env variables shouldn't error if not found

Open

#474 opened on Mar 19, 2025

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (34,142 stars) (1,320 forks)batch import
bug reporthelp wanted

Description

Description

the docker container will not start unless CHANGE_DETECTION_TOKEN is defined in the env file even if it is not being used in the config,

Contributor guide

Tech stack
godocker
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingEnvironment variable handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Look at how the Docker container starts and where environment variables like CHANGE DETECTION TOKEN are required. The error likely occurs during config loading. Find the code that checks for this variable and modify it to ignore commented out lines. Check the issue comments (issue #474) for any maintainer hints. Focus on the config parsing logic, possibly in files like `config.go` or `env.go`. Ensure that if the line is commented (e.g., starts with #), the variable is not mandatory.