gitui-org/gitui

show newer commits if on detached head

Open

#1,964 opened on Nov 27, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (21,937 stars) (721 forks)batch import
feature-requestgood first issue

Description

Right now the log starts from HEAD - no matter if that's a tip of a branch or not.

For #81 we need to do the revwalk from every tip and come up with a smart data structure that allows us to draw the correct graph without storing the whole graph in memory.

Before tackling #81 we can at least determine if we are on a detached head and then iterate the branches whether one is a descendent of our current HEAD and then start from the branch tip and visualize where HEAD is in the log.

Contributor guide

Tech stack
rust
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rustgit internalslibgit2
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue requires modifying the log display to start from the branch tip when HEAD is detached. First, examine the current log implementation in the repository, likely in the 'log' or 'graph' module. Use the libgit2 function `git graph descendant of` to check if any branch tip is a descendant of the current HEAD (detached). Then adjust the revision walk to start from that branch tip and show where HEAD is in the log. Refer to issue #81 for context on the desired data structure for graph drawing. The implementation should not store the full graph in memory but use a smart approach. There are no linked PRs or comments, so this is open for contribution.
show newer commits if on detached head · gitui-org/gitui#1964 | Good First Issue