gitui-org/gitui

improper background color patterns when scrolling file content

Open

#1,551 opened on Feb 17, 2023

View on GitHub
 (14 comments) (0 reactions) (0 assignees)Rust (721 forks)batch import
bugdormanthelp wanted

Repository metrics

Stars
 (21,937 stars)
PR merge metrics
 (Avg merge 41d 9h) (6 merged PRs in 30d)

Description

In the "Files [3]" I am trying to view the content of the files. When scrolling some background colors are not updated and a green-pink mess is seen. Unfortunately, I cannot attach the full screenshot due to private owned code. But please see the right side of guiui window where color glitches are seen.

OS/Distro: Debian 11 (Bullseye), Linux deb-ak 5.10.0-19-amd64 #1 SMP Debian 5.10.149-2 (2022-10-21) x86_64 GNU/Linux Terminals used where issue is observed: -- MATE Terminal -- xterm Rust version: 1.48 GitUi version: 0.22.1

image

Contributor guide

Research direction
Investigate the rendering logic for background colors during scroll, focusing on how the terminal pane updates when lines are scrolled. Look at the event handler for scroll actions and the function responsible for drawing the file content. Check if there is a failure to clear or reset background attributes when lines are moved or refreshed.
Tech stack
rust
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rustterminal rendering concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65