gitpoint/git-point

Replace deprecated React lifecycle methods

Open

#887 opened on Aug 27, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (837 forks)batch import
help wanted

Repository metrics

Stars
 (4,684 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

As suggested in https://github.com/gitpoint/git-point/pull/862#issuecomment-524167180, and more potential problems can be discovered by StrictMode.

  • componentWillMount
    • user/screens/starred-repository-list.screen.js
  • componentWillReceiveProps
    • auth/screens/events.screen.js
    • auth/screens/language-setting.screen.js
    • auth/screens/user-options.screen.js
    • notifications/screens/notifications.screen.js
    • organization/screens/organization-profile.screen.js
  • componentWillUpdate
    • None

Contributor guide

Research direction
Replace deprecated lifecycle methods in the specified files. For componentWillMount, move logic to componentDidMount or constructor. For componentWillReceiveProps, use getDerivedStateFromProps or componentDidUpdate. Test thoroughly.
Tech stack
reactjavascript
Domain
mobile
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70