gitpoint/git-point

Replace deprecated React lifecycle methods

Open

#887 opened on Aug 27, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (4,684 stars) (837 forks)batch import
help wanted

Description

As suggested in https://github.com/gitpoint/git-point/pull/862#issuecomment-524167180, and more potential problems can be discovered by StrictMode.

  • componentWillMount
    • user/screens/starred-repository-list.screen.js
  • componentWillReceiveProps
    • auth/screens/events.screen.js
    • auth/screens/language-setting.screen.js
    • auth/screens/user-options.screen.js
    • notifications/screens/notifications.screen.js
    • organization/screens/organization-profile.screen.js
  • componentWillUpdate
    • None

Contributor guide

Tech stack
javascriptreactreact native
Domain
mobilefrontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React lifecycle methodsReact Native basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Review the linked PR comment (https://github.com/gitpoint/git point/pull/862#issuecomment 524167180) and React StrictMode documentation. For each file in the checklist, examine the usage of deprecated lifecycle methods and plan replacements with appropriate modern alternatives (e.g., getDerivedStateFromProps, componentDidUpdate). Consider potential side effects and test after changes.