gitpoint/git-point

Icons and the sort of issue events

Open

#868 opened on Jan 23, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (4,684 stars) (837 forks)batch import
:bug: bughelp wanted

Description

  • Not every icon is in the center.
    • We need test function marginLeftForIconName in issue-event-list-item.component.js for every icons and update.
  • The sort doesn't always obey created time. Maybe caused by #848.
    • Some items have invalid created_at value.

Contributor guide

Tech stack
javascriptreact native
Domain
frontendmobiletesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React NativeJavaScriptGitPoint codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
First, examine `issue event list item.component.js` to find the `marginLeftForIconName` function and ensure it correctly centers all icons. Write a test for it. Second, investigate the sorting logic in the same component or related files; check the `created at` values from the API and ensure they are valid timestamps. The issue mentions PR #848 may have caused the sorting problem, so review that PR's changes to understand the impact. Finally, verify that the sorting order respects chronological order.