Read-only editors for action.yml shows problems as if it were a workflow

Open
#618 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
63/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
github-actions, typescript, vscode
Domain
ci-cd, tooling

Research direction

Reproduce the issue by opening a read-only diff for an action.yml file and observe the false-positive Problems. Start by tracing how the extension distinguishes action metadata from workflow YAML in diff views, then verify that the file is identified as an action and no workflow-specific Problems appear.

Written by the indexing model from the issue text.

Description

bug

Describe the bug

Some diffs (but not all!) show a load of false positive Problems for action.yml treating it as if it were a workflow YAML file.

Possibly this only affects read-only diffs.

To Reproduce
Steps to reproduce the behavior:

  1. Open a read-only diff of an action.yml file

Expected behavior
action.yml should be correctly identified as an action not a workflow, in diff views

Screenshots

Top: an unaffected diff; bottom: an affected read-only diff

Image

Extension Version
0.32.3

Additional context
(Originally opened in https://github.com/microsoft/vscode-pull-request-github/issues/8873 but it affects diffs unrelated to PRs)

Dominant language
TypeScript
Stars
661
Forks
214
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from github/vscode-github-actions

All issues in github/vscode-github-actions

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.