github/vscode-github-actions

Highlighting of multi-line `if` fields

Open

#333 opened on May 28, 2024

View on GitHubContributor guide
 (4 comments) (3 reactions) (0 assignees)TypeScript (204 forks)auto 404
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (656 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? Please describe. I often use a complex if field to enable smart skipping of the push event trigger. image (note that without the ${{ }} the editor yields a syntax error saying Unexpected symbol: '=='. Adding a space after the initial ! seems to eliminate the error, but I'm not sure if that works (#290).)

Writing it like that looks horrible so I format it as a multi-line string, but then the syntax highlighting is broken. image

Describe the solution you'd like It would be really nice to have syntax highlighting for multi-line expressions. It would look something like this: image

Contributor guide

Research direction
Find the syntax highlighting rules in the extension's grammar file and add support for multi line expressions in `if` fields.
Tech stack
typescript
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80