Failing integration tests when running locally
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- typescript, vscode
- Domain
- devtools, testing-qa
Research direction
Start with extensions/ql-vscode/src/vscode-tests/cli-integration/databases.test.ts, especially the "should add a database from a folder" test, and run the integration tests repeatedly in a local environment. Inspect how temporary databases are created and cleaned up; done means the test passes on subsequent runs without manually deleting /private/var/folders/.../tmp-* databases.
Written by the indexing model from the issue text.
Description
When running integration tests locally, they pass the first time you run them and fail subsequently.
In particular, extensions/ql-vscode/src/vscode-tests/cli-integration/databases.test.ts should add a database from a folder fails. And I can get it passing if I clear out all of the vscode temporary databases in /private/var/folders/41/kxmfbgxj40dd2l_x63x9fw7c0000gn/T/tmp-*. (This is likely a different folder on different machines.)
The integration tests are passing on CI because they always run in a clean state.
I can think of two possibilities that might fix the problem:
- Run cleanup code (eg- delete all databases) after running all the tests
- Ensure we have a clean slate before starting any tests.
version: CodeQL extension version: 1.5.6 CodeQL CLI version: 2.6.3 Platform: darwin x64
- Dominant language
- TypeScript
- Stars
- 539
- Forks
- 240
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 37
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/vscode-codeql
-
bug VSCode
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
github/vscode-codeql#4471 · 1 comment ·
-
bug enhancement VSCode
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
github/vscode-codeql#592 · 2 comments ·
-
enhancement VSCode
Difficulty 3/5 1-2 days Newbie friendliness 55/100
github/vscode-codeql#4432 · 1 comment ·
-
bug VSCode
Difficulty 3/5 1-2 days Newbie friendliness 52/100
github/vscode-codeql#4356 ·
-
bug VSCode
Difficulty 3/5 1-2 days Newbie friendliness 64/100
github/vscode-codeql#4339 · 1 comment ·
All issues in github/vscode-codeql
Similar issues
-
blocklist removal
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
MetaMask/eth-phishing-detect#296544 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
pastelsky/bundlephobia#1122 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
category/development priority/P2 scope/file-operations scope/testing type/enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Enatega Customer and Rider app: Add-ons price is not visible to customer after order is placed. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100