Crash when CodeQL evaluator log summary is too large

Open
#2,787 2 comments 0 reactions 2 assignees View on GitHub

@angelapwen is already working on this.

Since Sep 6, 2023.

Assessment

This issue has not been assessed yet.

Description

bug VSCode

Reported by several internal users:

[2023-09-06 14:13:16] Evaluation of .../code/ql/java/ql/src/Security/CWE/CWE-022/TaintedPath.ql produced BQRS results.
Error running query: Cannot create a string longer than 0x1fffffe8 characters (codeQL.quickEvalContextEditor)
Error: Error running query: Cannot create a string longer than 0x1fffffe8 characters
    at Object.slice (node:buffer:599:37)
    at Buffer.toString (node:buffer:819:14)
    at readFileHandle (node:internal/fs/promises:427:36)
    at generateSummarySymbols (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:144496:19)
    at generateSummarySymbolsFile (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:144492:19)
    at generateEvalLogSummaries (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:144889:7)
    at LocalQueryRun.summarizeEvalLog (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:145690:26)
    at LocalQueryRun.complete (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:145668:26)
    at LocalQueries.compileAndRunQueryInternal (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:146085:9)
    at LocalQueries.compileAndRunQuery (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:146025:5)
    at withProgress.title (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:145904:9)

The suspicion is that the log summary is too large to load as a single string, so we need to stream it.

Dominant language
TypeScript
Stars
539
Forks
240
Avg merge
2d 6h
Merged PRs (30d)
29

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from github/vscode-codeql

All issues in github/vscode-codeql

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.