Add the concept of an active query
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 30/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- typescript, vscode
- Domain
- developer-experience, tooling
Research direction
No repository files or tests are named. Start by locating the extension's registration for the codeQL.runQuery command and the VS Code workspace-state handling shown in the proof of concept. Done should include a way to choose an open .ql file as the active query and run it from another file, while still allowing the query in the active tab to take precedence.
Written by the indexing model from the issue text.
Description
Is your feature request related to a problem? Please describe.
When I'm working on a query I'm often in editing other files like .qll files, but still want to run the primary query after making a change. I'm in the habit of pressing the key binding for running a query, but this doesn't work from .qll files, so I need to switch tabs back to the original query and then run it. This gets annoying over time.
Describe the solution you'd like
If I know I only want to work on a single query, it would be useful to specify this query once, and then have a key binding for running the active query from any file.
Additional context
I've prototyped this feature in a separate extension and it's been working well for me:
function getQLFileFromTab(tab: vscode.Tab): string | null {
if (tab.input === undefined) {
return null;
}
const tabInput = tab.input as vscode.TabInputText
if (tabInput.uri === undefined) {
return null;
}
const path: string = tabInput.uri.fsPath
if (path.endsWith(".ql")) {
return path
}
return null;
}
context.subscriptions.push(vscode.commands.registerCommand('gsgx.runActiveCodeQLQuery', async () => {
const activeTab = vscode.window.tabGroups.activeTabGroup.activeTab
let activeTabPath = null;
if (activeTab !== undefined) {
activeTabPath = getQLFileFromTab(activeTab)
if (activeTabPath !== null) {
vscode.commands.executeCommand("codeQL.runQuery",
vscode.Uri.file(activeTabPath)
);
return;
}
}
const activeQuery = <string>context.workspaceState.get("codeql.active-query");
if (activeQuery) {
vscode.commands.executeCommand("codeQL.runQuery",
vscode.Uri.file(activeQuery)
);
} else {
vscode.window.showInformationMessage('No active query');
}
}));
class QLFileQuickPickItem implements vscode.QuickPickItem {
label: string;
path: string;
detail: string;
constructor(path: string) {
this.path = path
this.detail = path
this.label = basename(path)
}
}
context.subscriptions.push(vscode.commands.registerCommand('gsgx.setActiveCodeQLQuery', async () => {
let openFiles = []
const activeTab = vscode.window.tabGroups.activeTabGroup.activeTab
let activeTabPath = null;
let activeTabFiles = []
if (activeTab !== undefined) {
activeTabPath = getQLFileFromTab(activeTab)
if (activeTabPath !== null) {
activeTabFiles.push(new QLFileQuickPickItem(activeTabPath))
}
}
console.log(activeTabPath)
for (const tg of vscode.window.tabGroups.all) {
for (const tab of tg.tabs) {
const path = getQLFileFromTab(tab)
if (path === null) {
continue
}
const item = new QLFileQuickPickItem(path)
if (tab.isActive) {
if (activeTabPath != path) {
activeTabFiles.push(item)
}
} else {
openFiles.push(item)
}
}
}
// activeTabFiles come first
openFiles.unshift(...activeTabFiles)
if (openFiles.length != 0) {
const result = await vscode.window.showQuickPick(openFiles, {
title: "Query path",
canPickMany: false,
});
await context.workspaceState.update("codeql.active-query", result?.path)
} else {
vscode.window.showInformationMessage("No CodeQL files are open")
}
}));
This is just a proof of concept to start a discussion about how this feature should work, if you think it makes sense to add it.
In this implementation, you can set any QL file that is in an open tab to the active query (in addition to this, it would probably be good to have an option in the right click context menu in the file explorer to set an active query).
Also, if another .ql file is in the active tab, it will always run that QL file instead of the active one. The reason for this is I occasionally do need to run other queries, but don't want to change the active query. It's convenient and intuitive to always run the query in the active tab first, and if the active tab is not a .ql file, then run the active query.
Please let me know what you think.
- Dominant language
- TypeScript
- Stars
- 539
- Forks
- 240
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 29
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/vscode-codeql
-
bug VSCode
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
github/vscode-codeql#4471 · 1 comment ·
-
bug enhancement VSCode
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
github/vscode-codeql#592 · 2 comments ·
-
enhancement VSCode
Difficulty 3/5 1-2 days Newbie friendliness 55/100
github/vscode-codeql#4432 · 1 comment ·
-
bug VSCode
Difficulty 3/5 1-2 days Newbie friendliness 52/100
github/vscode-codeql#4356 ·
-
bug VSCode
Difficulty 3/5 1-2 days Newbie friendliness 64/100
github/vscode-codeql#4339 · 1 comment ·
All issues in github/vscode-codeql
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
dennys-bd/agent-hive#184 ·
-
Add: hunch Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
AbdelStark/awesome-typesafe#104 ·
-
ai-observability bug team/ai-observability
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
vicharanashala/fln#563 ·