Running tests can try to run non-tests as tests
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- typescript, vscode
Research direction
Reproduce the failure by opening the codeql-coding-standards repository and running the c folder from the testing pane. Inspect the folder-run path and compare passing --strict-test-discovery with explicitly passing discovered tests; done means non-test packs are not attempted as tests and the test packs still run.
Written by the indexing model from the issue text.
Description
Describe the bug
When you have a folder that contains both multiple test packs and non-test packs, it will appear as runnable in the UI with the test packs a subpacks. When you run that folder it will also run the non-tests ibnside it as well.
Version
CodeQL extension version: 1.6.11
CodeQL CLI version: 2.10.3
Platform: linux x64
To reproduce
Open https://github.com/github/codeql-coding-standards/tree/next
Run the c folder in the testing pane. See codeql fail to find the extractor for a non-test folder.
Expected behavior
Only to try run the tests as tests.
Additional context
This can be seen by trying to run the c folder on https://github.com/github/codeql-coding-standards/tree/next
I think we either need to pass --strict-test-discovery when running or explicitly pass the set of tests rather than the folder.
- Dominant language
- TypeScript
- Stars
- 539
- Forks
- 240
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 29
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/vscode-codeql
-
bug VSCode
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
github/vscode-codeql#4471 · 1 comment ·
-
bug enhancement VSCode
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
github/vscode-codeql#592 · 2 comments ·
-
enhancement VSCode
Difficulty 3/5 1-2 days Newbie friendliness 55/100
github/vscode-codeql#4432 · 1 comment ·
-
bug VSCode
Difficulty 3/5 1-2 days Newbie friendliness 52/100
github/vscode-codeql#4356 ·
-
bug VSCode
Difficulty 3/5 1-2 days Newbie friendliness 64/100
github/vscode-codeql#4339 · 1 comment ·
All issues in github/vscode-codeql
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
safetrustcr/dApp-SafeTrust#426 ·
-
area:workflow bug ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
fil-donadoni/tolaria#4409 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Fission-AI/OpenSpec#1960 ·
-
Add dependabot Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
corsairdev/corsair#1764 ·