github/vscode-codeql

Bad error when opening quick query without a workspace folder.

Open

#1,415 opened on Jun 29, 2022

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)TypeScript (236 forks)auto 404
VSCodebuggood first issue

Repository metrics

Stars
 (530 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug Quick query didn't open without a workspace folder

The error is : Workspace storage path is undefined (codeQL.quickQuery)

Stack trace:

Workspace storage path is undefined (codeQL.quickQuery)
Error: Workspace storage path is undefined
    at getQuickQueriesDir (/home/alex/.vscode/extensions/github.vscode-codeql-1.6.7/out/quick-query.js:23:15)
    at displayQuickQuery (/home/alex/.vscode/extensions/github.vscode-codeql-1.6.7/out/quick-query.js:48:34)
    at ctx.subscriptions.push.title (/home/alex/.vscode/extensions/github.vscode-codeql-1.6.7/out/extension.js:542:159)
    at /home/alex/.vscode/extensions/github.vscode-codeql-1.6.7/out/commandRunner.js:39:16
    at w._withProgress (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:81:43330)
    at withProgress (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:81:43084)
    at Object.withProgress (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:97:42013)
    at withProgress (/home/alex/.vscode/extensions/github.vscode-codeql-1.6.7/out/commandRunner.js:38:28)
    at /home/alex/.vscode/extensions/github.vscode-codeql-1.6.7/out/commandRunner.js:111:26
    at o._executeContributedCommand (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:83:31333)
    at o.$executeContributedCommand (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:83:32037)
    at s._doInvokeHandler (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:86:13828)
    at s._invokeHandler (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:86:13512)
    at s._receiveRequest (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:86:12173)
    at s._receiveOneMessage (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:86:10843)
    at /usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:86:8949
    at m.invoke (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:58:145)
    at b.deliver (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:58:2265)
    at v.fire (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:58:1843)
    at l.fire (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:66:19001)
    at /usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:102:34426
    at m.invoke (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:58:145)
    at b.deliver (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:58:2265)
    at v.fire (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:58:1843)
    at l.fire (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:66:19001)
    at r._receiveMessage (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:66:23582)
    at /usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:66:21116
    at m.invoke (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:58:145)
    at b.deliver (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:58:2265)
    at v.fire (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:58:1843)
    at v.acceptChunk (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:66:15832)
    at /usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:66:14962
    at Socket.R (/usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:102:13798)
    at Socket.emit (node:events:390:28)
    at addChunk (node:internal/streams/readable:315:12)
    at readableAddChunk (node:internal/streams/readable:289:9)
    at Socket.Readable.push (node:internal/streams/readable:228:10)
    at Pipe.onStreamRead (node:internal/stream_base_commons:199:23)

To reproduce

Try to launch quick query without a folder open.

Expected behavior

A sensible error.

Additional context Add any other context about the problem here.

Contributor guide

Research direction
Inspect the getQuickQueriesDir function in quick query.js and trace how workspace storage path is obtained. Add a check for undefined workspace storage path and display a friendly error message.
Tech stack
typescriptnodejs
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.jsTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75