fix noisy update license PR
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- github-actions
- Domain
- ci-cd
Research direction
Locate the nightly license-update workflow and inspect how it compares source licenses with the existing pull request branch. Reproduce the no-change third-night case, then verify that the workflow exits early when the PR branch already contains the latest license files while still updating for a genuinely new license.
Written by the indexing model from the issue text.
Description
Description
A cron job runs nightly to keep the list of license up to date. It is supposed to exit early if there haven't been any changes since the last update of the PR it manages. But once there is a change to license files, it always registers a change.
Expected Behavior
- cron runs 1st night and there are no new licenses -- workflow exits early
- cron runs 2nd night and there are 2 new licenses -- creates the branch, makes a commit with the new licenses, and creates a PR
- cron runs 3rd night and there are no new licenses -- workflow exits early
- cron runs 4th night and there is 1 new license -- creates a commit to the existing branch with the new license and updates the existing PR
Actual Behavior
- cron runs 1st night and there are no new licenses -- workflow exits early (CORRECT)
- cron runs 2nd night and there are 2 new licenses -- creates the branch, makes a commit with the new licenses, and creates a PR (CORRECT)
- cron runs 3rd night and there are no new licenses -- updates the existing PR (WRONG)
- cron runs 4th night and there is 1 new license -- creates a commit to the existing branch with the new license and updates the existing PR (CORRECT)
The PR updates on the 3rd night because the source licenses are being compared against the main branch instead of the PR's branch. This makes the license files appear to be different even though there are no new changes on the 3rd night.
- Dominant language
- Go
- Stars
- 53
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/go-spdx
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
maintenance
Difficulty 1/5 1-3 hours Newbie friendliness 45/100
-
documentation
Difficulty 5/5 Over a week Newbie friendliness 25/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
enhancement needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
kind/cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
kubernetes-sigs/kueue#15947 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·