Error given when a push fails due to hook failure is not useful
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 65/100
Research direction
Reproduce the failure with a pre-push hook using gh stack sync, gh stack push, and gh stack submit, then inspect the push error handling for those commands. Preserve and surface the hook's useful error output instead of only reporting that refs failed; verify the resulting messages against a regular git push.
Written by the indexing model from the issue text.
Description
I have a pre-push hook setup on my local repos.
When I try gh stack sync it results in this:
Pushing 3 branches to origin...
⚠ Push failed — branches may need force push after rebase
When I try gh stack push it results in this:
Pushing 3 branches to origin...
✗ failed to push: failed to run git: error: failed to push some refs to 'github.com:<my_repo>'
When I try gh stack submit it results in this:
Pushing to origin...
✗ failed to push <my_branch>: failed to run git: error: failed to push some refs to 'github.com:<my_repo>'
Eventually I was able to guess it was my pre-push hook and tried a regular push and it told me what the error was immediately.
- Dominant language
- Go
- Stars
- 1.5k
- Forks
- 73
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 7
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/gh-stack
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
feature request topic: cli - general
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
feature request topic: auto-merge
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
bug topic: docs
Difficulty 1/5 Under an hour Newbie friendliness 68/100
Similar issues
-
feature-request helm
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
gravitational/teleport#69785 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
crossplane/crossplane#7859 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100