Getting Every PR in this stack has already been merged, when there is a PR already
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 48/100
Research direction
Reproduce the sequence where branch3 is created while branch2 is in the merge queue, then run gh stack unstack and create a PR for branch4. Inspect the stack and PR creation flow to determine why it reports every PR as merged despite the resulting UI appearing correct. Done means the sequence no longer produces an inaccurate merged-stack warning or leaves the stack state inconsistent.
Written by the indexing model from the issue text.
Description
So I had branch 1 and branch 2 that created normally, and then branch3 was created while branch2 was in merge queue.
Then the git diff went weird but I fixed the merge conflicts, and thought maybe I'd try to gh stack unstack, but it didn't allow me because it was still part of the stack. Oh well, I continued on and tried making a PR for branch4 and got this.
⚠ Every PR in this stack has already been merged on GitHub
Adding to a fully merged stack isn't supported — starting a new stack for your 2 unmerged branches based on master
Pushing to origin...
PR #52141 for branch3
✓ Created PR #52148 for branch4
✓ Stack created on GitHub with 2 PRs (stack #52149)
✓ Pushed and synced 2 branches
Everything looks good on the UI though
- Dominant language
- Go
- Stars
- 1.5k
- Forks
- 73
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 7
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/gh-stack
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
feature request topic: cli - general
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
feature request topic: auto-merge
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
bug topic: docs
Difficulty 1/5 Under an hour Newbie friendliness 68/100
Similar issues
-
textual definition
Difficulty 1/5 Under an hour Newbie friendliness 90/100
geneontology/go-ontology#32653 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
-
needs design
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Priority/High ready-for-agent Severity/Major Type/Bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100