`gh stack submit` with PULL_REQUEST_TEMPLATE.md that has `CRLF` line endings
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 55/100
Research direction
Reproduce the issue on Windows with a CRLF PULL_REQUEST_TEMPLATE.md, then trace the gh stack submit path that loads the template and opens the editor. Confirm the fix by checking that the template displays without extra line endings and that the existing workaround is no longer needed.
Written by the indexing model from the issue text.
Description
Problem
Submit is rendering extra line endings when it sees CRLF. Opening in the $EDITOR also has these extra line endings.
Descirption
When developing on Windows, it is common for git to normalize line endings to CRLF and then back to LF on commit.
On Windows, given a template with the following:
It opens in the submit editor like this (each red mark is an extra newline):
I replaced CRLF with LF, and then it works fine.
I have workarounds, just a minor inconvenience.
- Dominant language
- Go
- Stars
- 1.5k
- Forks
- 73
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 7
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/gh-stack
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
feature request topic: cli - general
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
feature request topic: auto-merge
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
bug topic: docs
Difficulty 1/5 Under an hour Newbie friendliness 68/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
NVIDIA/gpu-operator#2955 ·
-
agentic-workflows
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
kovidgoyal/kitty#10516 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
cisagov/vulnrichment#337 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100