Make submit shortcut configurable (or change default from `Ctrl+S`)
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
Research direction
Start by locating the stack submission UI and the handler for the current Ctrl+S shortcut, then inspect how gh-stack receives terminal input. Decide on the supported binding behavior from the proposal and verify that submission works with the chosen shortcut without relying on Ctrl+S.
Written by the indexing model from the issue text.
Description
Summary
In the stack submission UI, Ctrl+S is used to submit to GitHub. Could we make this shortcut configurable (and/or consider a different default)?
Problem
Ctrl+S commonly maps to "save" in many terminal editors/tools, and in some terminal environments it can conflict with user expectations or existing keybindings. This can lead to accidental submissions or friction when switching contexts. In my case I was unable to submit my stack since Ctrl+S is being hijacked by my terminal and the gh TUI was never able to receive it.
Proposal
One of the following (in order of preference):
- Add configurable keybindings for TUI actions (including submit), with a sensible default.
- Keep
Ctrl+Sas an optional binding but add an additional default (e.g.Enteron focused submit,Ctrl+Enter, orsin a specific mode). - If full keybinding customization is out of scope, switch the default submit shortcut to a less collision-prone key combo.
Additional context
Current behavior observed in stack submission flow where Ctrl+S triggers submit.
- Dominant language
- Go
- Stars
- 1.5k
- Forks
- 73
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 7
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/gh-stack
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
feature request topic: cli - general
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
feature request topic: auto-merge
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
bug topic: docs
Difficulty 1/5 Under an hour Newbie friendliness 68/100
Similar issues
-
textual definition
Difficulty 1/5 Under an hour Newbie friendliness 90/100
geneontology/go-ontology#32653 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
-
needs design
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Priority/High ready-for-agent Severity/Major Type/Bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100