[Bug] Stacked PR squash merges can combine the PR author's name with the merger's email
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 30/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Active
- Tech stack
- git, github
- Domain
- cli
Research direction
No source file, test, or entry point is identified. Start by comparing the linked pull requests with their generated squash commits and determine whether gh-stack has a relevant merge path; done should mean the mixed author identity is reproducibly explained and a concrete project-scoped change is defined.
Written by the indexing model from the issue text.
Description
Description
When a native GitHub Stacked PR is squash-merged by someone other than the PR author, the generated commit can contain a mixed author identity:
- The Git author name belongs to the PR author.
- The Git author email belongs to the user who merged the stack.
The original commits are correctly associated with the PR author. The incorrect email is introduced when GitHub creates the squashed commit.
As a result, the repository page may display the PR author's name while the API, contribution graph, contributor statistics, and other author-based tooling attribute the commit to the merger.
Public examples
- Dominant language
- Go
- Stars
- 1.5k
- Forks
- 73
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 7
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/gh-stack
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
feature request topic: cli - general
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
feature request topic: auto-merge
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
bug topic: docs
Difficulty 1/5 Under an hour Newbie friendliness 68/100
Similar issues
-
textual definition
Difficulty 1/5 Under an hour Newbie friendliness 90/100
geneontology/go-ontology#32653 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
-
needs design
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Priority/High ready-for-agent Severity/Major Type/Bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100