github/gh-ost

Request for assistance: mapping charsets

Open

#228 opened on Sep 9, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (8,101 stars) (819 forks)batch import
help wantedsuggested for community contribution

Description

Matter at hand: gh-ost's support for multiple charsets.

gh-ost works well out-of-the-box with utf8 and utf8mb4.

However for other character sets it needs to be told, explicitly, how to convert strings. For example, the latin1 character set is supported, and is converted via golang's charmap.Windows1252, see: https://github.com/github/gh-ost/blob/master/go/sql/encoding.go#L20

If anyone is willing to assist in mapping other MySQL charsets to golang Encoders, we're very grateful. Please PR the https://github.com/github/gh-ost/blob/master/go/sql/encoding.go file with additional charsets.

Contributor guide

Tech stack
gomysql
Domain
databasebackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingMySQL charset knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the encoding.go file at go/sql/encoding.go to understand how the existing Windows1252 mapping is implemented. Research commonly used MySQL charsets like latin1, cp1251, utf16, etc., and find corresponding Go encoding packages (e.g., golang.org/x/text/encoding). Add mappings for each charset by implementing the Encoder interface. Test with sample data to ensure correct conversion.