gl2gh migrate-repo: log message after successful migration gives incorrect log file URL for ghe.com targets
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
Research direction
Start in src/gl2gh/Commands/MigrateRepo/MigrateRepoCommandHandler.cs around lines 245-255, where the migrationLogUrl and post-migration hint are assembled. Reproduce a GitLab-to-ghe.com migration with --target-api-url and --target-uploads-url, then verify the suggested download-logs command uses the target API endpoint and can retrieve the migration log.
Written by the indexing model from the issue text.
Description
Description
When running gh gl2gh migrate-repo to migrate a GitLab repository to a GitHub data residency (ghe.com) target (--target-api-url and --target-uploads-url are supplied) the migrate-repo command itself prints a hint after the migration completes (or fails) suggesting how to re-fetch the migration log. The link in this hint is incorrect, because it doesn't take the target-api-url into account. The migrationLogUrl in this code snippet doesn't have the correct URL and needs to be fixed:
The download-logs command itself works correctly when --target-api-url is supplied. If a user copies and runs the suggested command from the hint of migrate-repo as-is, it defaults to https://api.github.com instead of the tenant's ghe.com API endpoint, so it queries the wrong GitHub instance and fails to find (or returns an incorrect) migration log.
Reproduction Steps
Run a regular GitLab to GitHub ghe.com migration and try to open the logs from the CLI.
- Dominant language
- C#
- Stars
- 479
- Forks
- 148
- Avg merge
- 7d 21h
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/gh-gei
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
task
Difficulty 1/5 Under an hour Newbie friendliness 68/100
-
task
Difficulty 1/5 Under an hour Newbie friendliness 65/100
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
Similar issues
-
type/automation type/tech-debt
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
t/bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
ci-failure-cause test-failure
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
area:auth FE mvp P3
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
klasolsson81/jobbliggaren#1788 ·