Linting fails after forking and cloning
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 58/100
Research direction
Start at pkg/classroom/classroom.go:144, where the reported govet error occurs in the fmt.Sprintf call. Run golangci-lint run and go test -v ./... before and after the change; done means the lint error is resolved and the test suite still passes.
Written by the indexing model from the issue text.
Description
I was going to fix the error in CONTRIBUTING.md I mentioned in Issue #95. The golangci-lint run command results in the following...
gh-classroom on main via 🐹 v1.23.6 took 18s
❯golangci-lint run
pkg/classroom/classroom.go:144:21: printf: non-constant format string in call to fmt.Sprintf (govet)
return fmt.Sprintf(a.Classroom.Url)
Context
Platform
MacOS
Also replicated it on CachyOS Linux (Arch based distro)
Submitting a pull request
-
[Fork](https://github.com/github/gh-classroom/fork) and clone the repository -
Configure and install the dependencies: `go mod tidy` -
Make sure the tests pass on your machine: `go test -v ./...` -
Make sure linter passes on your machine: `golangci-lint run` <----- This line causes the error -
Create a new branch: `git checkout -b my-branch-name` -
Make your change, add tests, and make sure the tests and linter still pass -
Push to your fork and [submit a pull request](https://github.com/github/gh-classroom/compare) -
Please be patient while waiting for your pull request to be reviewed and merged.
- Dominant language
- Go
- Stars
- 126
- Forks
- 21
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/gh-classroom
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
github/gh-classroom#95 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
github/gh-classroom#21 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
github/gh-classroom#116 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
github/gh-classroom#110 ·
-
Sanitize Team name Open
Difficulty 3/5 1-2 days Newbie friendliness 45/100
github/gh-classroom#109 ·
All issues in github/gh-classroom
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 60/100
github/gh-aw-mcpg#13748 ·
-
agentic-workflows
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
googleapis/librarian#7670 · 2 comments ·