`A15-4-4`: Query incorrectly alerts functions that raise/can raise exceptions

Open

#824 opened on Dec 17, 2024 0 comments 0 reactions 1 assignee View on GitHub

@rak3-sh is already working on this.

Since Dec 22, 2024.

Assessment

This issue has not been assessed yet.

Description

Difficulty-Medium false positive/false negative Impact-Low

Affected rules

A15-4-4

Description

Query doesn’t consider ReThrowExpr. E.g. the query says to mark rethrow() below as noexcept

Example

template <bool DoRethrow>
void rethrow() {
  throw;
}

int main()
{
  rethrow<true>();
  return 0;
}

The query doesn’t check for throw expressions that occur inside lambdas defined in a function. E.g.

Example

void func()  {
    std::call_once(init_flag_, [this] {
      if (sem_init(&sem_, 0, 0) != 0) {
        throw std::system_error(errno, std::system_category()); // Throw in a lambda.
      }
      initialized_ = true;
    });
  }

In some cases the noexcept specification is a complex condition involving several logical operations or template instantiations. In such a case, CodeQL’s check for whether its noexcept(true) or noexcept explicitly false doesn’t work and it alerts that it can be marked as noexcept. For practical reasons, maybe we can consider a noexcept(expr) as being marked by the user as correct.

Dominant language: CodeQL
Stars: 227
Forks: 82
Avg merge: 6d 7h
Merged PRs (30d): 9

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

`A15-4-4`: Query incorrectly alerts functions that raise/can raise exceptions

Assessment

Description

Affected rules

Description

Example

Example

Contributor guide

First steps

More from github/codeql-coding-standards

Get new issues in your inbox