`A1-1-2`: does not understand -Wno-* flags

Open

#689 opened on Sep 17, 2024 1 comment 0 reactions 1 assignee View on GitHub

@MichaelRFairhurst is already working on this.

Since Sep 18, 2024.

#688 by @MichaelRFairhurst — merged

Assessment

This issue has not been assessed yet.

Description

Difficulty-Low false positive/false negative Impact-Medium Standard-AUTOSAR

Affected rules

A1-1-2

Description

This rule looks for compilations with no warning flags. However, it will falsely detect -Wno-* flags as if they are warning flags.

Notably, gcc is often built with -Wformat enabled by default. This can be suppressed with -Wno-format, which would cause the false negative.

Note the same issue exists with -w which suppresses all -W* flags, which is failing linux/gcc tests, and I created https://github.com/github/codeql-coding-standards/pull/688 to fix. However, this issue is, philosophically, one step further yet than that PR in terms of altering current behavior.

Example

g++ -Wno-format test.cpp

Dominant language: CodeQL
Stars: 227
Forks: 82
Avg merge: 6d 7h
Merged PRs (30d): 9

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

`A1-1-2`: does not understand -Wno-* flags

Assessment

Description

Affected rules

Description

Example

Contributor guide

First steps

More from github/codeql-coding-standards

Get new issues in your inbox