A13-3-1: reconsider precision and feasibility of rule exception

Open
#524 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
cpp
Domain
devtools

Research direction

No file or test is named in the issue. Start by locating the current rule implementation and comparing it with the standard’s exception, then assess whether enable_if-based checks can distinguish constrained explicit constructors whose argument types resolve on invocation. Done means deciding whether the exception is feasible and valuable, with an agreed implementation scope.

Written by the indexing model from the issue text.

Description

Standard-AUTOSAR

the standard lists an exception where some explicit constructors may be constrained and therefore not actually overload implicit copy/move ctors.

the current implementation does not cover this,

further consideration is required to determine if the exception is possible and also valuable

consider the following :
not c.getTemplateArgument(_).toString().matches("%enable_if%") or maybe not c.getTemplateArgumentKind(_).toString().matches("%enable_if%")
but this wont work for functions where the types in the argument actually resolve if the function is called

Dominant language
CodeQL
Stars
227
Forks
82
Avg merge
6d 7h
Merged PRs (30d)
9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from github/codeql-coding-standards

All issues in github/codeql-coding-standards

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.