Deviation code identifier and expanded macro elements
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Reproduce the issue with the multiline C++ macro example and the code identifier beside the offending parameter. Trace how CodeQL Coding Standards handles deviations on expanded macro elements, then verify that the identifier suppresses the guideline there as well as when placed on the final macro-invocation line.
Written by the indexing model from the issue text.
Description
Describe the bug
Whenever a guideline is positioned on an expanded element of a macro invocation spanning multiple lines, a deviation using a code identifier fails to suppress the guideline when position next to the offending parameter.
Macro(X,
Y, // CODE-IDENTIFIER
Z
)
To Reproduce
See example above
Expected behavior
Suppression of guideline
Screenshots
n/a
Environment
- CodeQL Coding Standards version: e.g. 0.7.0
- CodeQL version: 2.10.5
- Operating System: MacOS, Linux
Additional context
A current workaround is to place the code identifier on the last line of the macro invocation instead of the offending program element (e.g., macro invocation parameter)
Macro(X,
Y,
Z,
) // CODE-IDENTIFIER
- Dominant language
- CodeQL
- Stars
- 227
- Forks
- 82
- Avg merge
- 6d 7h
- Merged PRs (30d)
- 9
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from github/codeql-coding-standards
-
false positive/false negative Stardard-MISRA-C++
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
github/codeql-coding-standards#1172 ·
-
Difficulty-Low false positive/false negative false-negative Impact-Low Standard-MISRA-C
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty-Medium false positive/false negative false-positive Impact-Medium Standard-CERT-C
Difficulty 4/5 3-5 days Newbie friendliness 48/100
github/codeql-coding-standards#1200 ·
-
`RULE-0-0-1`: "unreachable statement" false positives due to over-pruning of the control-flow graph Openfalse positive/false negative
Difficulty 4/5 3-5 days Newbie friendliness 48/100
github/codeql-coding-standards#1190 ·
-
false positive/false negative
Difficulty 3/5 1-2 days Newbie friendliness 65/100
github/codeql-coding-standards#1175 ·
All issues in github/codeql-coding-standards
Similar issues
-
ZCode 3.14.3 に対応する Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
supermomonga/zcode-acp#24 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
learningequality/ricecooker#747 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
KhronosGroup/glTF-Blender-IO#2769 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100