`RULE-15-1-4`: Aggregate member initialized with "{}" falsely flagged

Open
#1,165 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
cpp
Domain
devtools

Research direction

Start by locating the RULE-15-1-4 query and its existing tests, then reproduce the C++ example from this issue. Update the rule so aggregate member initialization with {} is not falsely flagged, and verify that the relevant test coverage distinguishes it from a genuine violation.

Written by the indexing model from the issue text.

Description

false positive/false negative Stardard-MISRA-C++
Affected rules
  • RULE-15-1-4
Description

It seems that we're checking if this field has an "initializer" and that's not the case in the database so we get a false positive.

Example
class C1 {
  size_t x = static_cast<size_t>(0);
};

class C2 {
  C2() {}; // False positive here
  C1 y {}; // is initialized by this syntax but apparently does not have an initializer...
Dominant language
CodeQL
Stars
227
Forks
82
Avg merge
6d 7h
Merged PRs (30d)
9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from github/codeql-coding-standards

All issues in github/codeql-coding-standards

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.