`RULE-5-13-4`: False unsuffixed literal reported for T{} class member initializer

Open
#1,164 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
cpp
Domain
tooling

Research direction

Start with the RULE-5-13-1 query and its handling of nested aggregate classes. Reproduce the report using the C1 and C2 example, focusing on the false positive at C1 y{}. Add regression coverage showing that this initializer is not reported while the affected rule still detects its intended cases.

Written by the indexing model from the issue text.

Description

false positive/false negative
Affected rules
  • RULE-5-13-1
Description

Discovered on a QLX pull request. Likely related to the nested aggregate classes.

Example
class C1 {
  size_t x = static_cast<size_t>(0);
};

class C2 {
  C1 y{}; // falsely reported here
};
Dominant language
CodeQL
Stars
227
Forks
82
Avg merge
6d 7h
Merged PRs (30d)
9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from github/codeql-coding-standards

All issues in github/codeql-coding-standards

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.