Excluding labels will still show as deletion

Open Beginner friendly
#764 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
backend

Research direction

Start at lib/plugins/labels.js#L84 and trace how labels.exclude are handled when building the PR comment and issuing deletion calls. Verify the behavior in NOP mode as a reference. Done means excluded labels no longer appear in the deletion column or trigger the delete API call, while non-excluded labels retain their current behavior.

Written by the indexing model from the issue text.

Description

bug

Problem Description

When configuring labels.exclude to exclude some/all labels it will still show as a Deletion in PR context. After some looking into the code i think it shouldn't actually run the delete API call. (in NOP mode it also doesn't print the delete message) Link to exclude code block.

What is actually happening
  • Showing labels that should be exluded in the deletion column!
What is the expected behavior
  • Do not show any excluded labels in the PR Comment.

Context

Are you using the hosted instance of probot/settings or running your own?

self-hosted

If running your own instance, are you using it with github.com or GitHub Enterprise?

github.com

Version of probot/settings

2.1.16

Dominant language
JavaScript
Stars
922
Forks
227
Avg merge
18h 3m
Merged PRs (30d)
14

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from github-community-projects/safe-settings

All issues in github-community-projects/safe-settings

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.