git-up/GitUp

Stashed change selected is not persisted across changed tabs

Open

#871 opened on Oct 20, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Objective-C (1,464 forks)batch import
good first issue

Repository metrics

Stars
 (11,997 stars)
PR merge metrics
 (Avg merge 22h 44m) (4 merged PRs in 30d)

Description

Steps:

  1. Have at least 2 stashed changes in the "stashes" (CMD+3)
  2. Open "stashes" (CMD+3) and select 2nd stash, so that it becomes highlighted
  3. Open another tab, e.g. a tree (CMD+1) or a commit editor (CMD+2)
  4. Go back to the "stashes" (CMD+3)

Expected result:

  • The 2nd stash is still highlighted and selected

Actual result:

  • The selection always resets to the 1st stash regardless of what has been selected before.

Contributor guide

Research direction
Investigate the stash tab view controller in GitUp's source code. Look for how the selected stash index is stored when the user switches tabs and how it is restored upon returning. The bug suggests the selection resets to the first stash. Examine the view lifecycle methods and any state saving mechanisms. Consider implementing a simple property or user defaults to persist the selected index across tab switches.
Tech stack
objective c
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
XcodeObjective CGitUp codebase overview
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60