ghaiklor/passport-google-plus-token

Wrong or expired Google token cause error 500

Open

#50 opened on Mar 3, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (10 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (23 stars)
PR merge metrics
 (PR metrics pending)

Description

If a token is expired or broken, system returns 500 instead of 401:

InternalOAuthError: Invalid Credentials at c:\node_modules\passport-google-plus-token\lib\index.js:115:25 at passBackControl (c:\node_modules\oauth\lib\oauth2.js:123:9) at IncomingMessage. (c:\node_modules\oauth\lib\oauth2.js:143:7) at emitNone (events.js:72:20) at IncomingMessage.emit (events.js:166:7) at endReadableNT (_stream_readable.js:905:12) at nextTickCallbackWith2Args (node.js:441:9) at process._tickCallback (node.js:355:17)

Contributor guide

Research direction
Examine the passport google plus token strategy's error handling in lib/index.js around line 115. Modify the callback to return an HTTP 401 status instead of 500 when the token is invalid or expired.
Tech stack
javascriptnodejs
Domain
authenticationbackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.jsOAuth
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65