ggml-org/whisper.cpp

errorlevel not set when exiting with errors in windows version

Open

#555 opened on Mar 2, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (49,693 stars) (5,535 forks)batch import
enhancementgood first issue

Description

It seems to me that main.exe sets no errorlevel when it exits with error. IMHO it should not exit with errorlevel = 0

Contributor guide

Tech stack
cpp
Domain
backendcli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic C++ knowledgeunderstanding of Windows error codes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the error handling in main.cpp. The issue states that the Windows version exits without setting errorlevel. Look at the exit points in main() and check if they use appropriate Windows API functions like SetLastError() or return non zero exit codes. Consider how other cross platform exit code handling is done in the codebase. Ensure the fix sets the errorlevel correctly on Windows while preserving behavior on other platforms.