ggml-org/whisper.cpp

max-len as a range or 'suggestion' to reduce dangling tokens

Open

#543 opened on Feb 27, 2023

View on GitHub
 (1 comment) (2 reactions) (0 assignees)C++ (49,693 stars) (5,535 forks)batch import
enhancementgood first issue

Description

suggestion that the max-len argument allow for some ambiguity of +- words/tokens or a nargs range instead of a hard int, so that the output files don't dangle a single word/token on successive timestamps.

Ex: Given the following output, it would probably be preferrable that the 2nd and 5th timestamp (there/job) would appear with the previous timestamp, possibly hard-wrapped to a second line in the cue, rather than alone.

` [00:06:23.160 --> 00:06:27.000] The other district where Pat was over

[00:06:27.000 --> 00:06:27.000] there,

[00:06:27.000 --> 00:06:28.380] also they know her.

[00:06:28.380 --> 00:06:31.680] So I think they were doing a very good

[00:06:31.680 --> 00:06:32.400] job.

[00:06:32.400 --> 00:06:35.750] - So only those two candidates were the

[00:06:35.750 --> 00:06:36.160] only ones `

Contributor guide

Tech stack
cpp
Domain
backendcli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with C++Understanding of whisper.cpp command line parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
First, examine how the max len argument is currently parsed and applied in main.cpp. The issue suggests allowing a range or tolerance (e.g., an integer with a +/ value). Look at the argument parsing code, likely using argparse or similar. Then, modify the logic to accept a range and adjust the output formatting to avoid dangling single words. The comment in the issue provides example output showing the problem; use that to test the change.