ggml-org/whisper.cpp

OpenBLAS hardcoded in Makefile - and should we use it?

Open

#414 opened on Jan 16, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (5,535 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (49,693 stars)
PR merge metrics
 (Avg merge 5d 20h) (36 merged PRs in 30d)

Description

the path to openblas libraries is hardcoded as: /usr/local/include/openblas a la:

ifdef WHISPER_OPENBLAS
        CFLAGS  += -DGGML_USE_OPENBLAS -I/usr/local/include/openblas
        LDFLAGS += -lopenblas
endif

As I wish to give whisper.cpp all the help I can with libraries it can use (M1 arm64 MBP13"), I could install macports' version but it would probably be located in /opt/local/include/openblas (I'm assuming).

Should I install that and change the Makefile? Benefits?

Contributor guide

Research direction
Investigate how to make the OpenBLAS path configurable, e.g., by adding an environment variable or using pkg config to detect the installation path.
Tech stack
ccpp
Domain
backendbuild system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Makefile
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70