ggml-org/whisper.cpp

Node package ES6 compatibility

Open

#335 opened on Dec 26, 2022

View on GitHub
 (0 comments) (2 reactions) (0 assignees)C++ (49,693 stars) (5,535 forks)batch import
buildhelp wanted

Description

The node package that's currently built is not an ES6 compatible package.

I've tried adding the -s EXPORT_ES6 flag and it seems to work properly, but the output still has mixed usage of CommonJS requires and ES6 imports, which breaks things.

Contributor guide

Tech stack
nodejsjavascript
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Node.js package managementES6 module systemBuild configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate the build configuration for the Node.js package in the repository. Look at the package.json or build scripts where the s EXPORT ES6 flag is used. Ensure that the output is consistently ES6 modules, either by adjusting the build settings or converting remaining CommonJS requires. Refer to the Node.js documentation for ES6 module compatibility.