ggml-org/llama.cpp

Refactor: Add more typechecking to GGUFWriter.add_key_value

Open

#9,095 opened on Aug 19, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (18,202 forks)batch import
help wantedrefactoring

Repository metrics

Stars
 (110,169 stars)
PR merge metrics
 (Avg merge 5d 11h) (457 merged PRs in 30d)

Description

Background Description

As per this discussion https://github.com/ggerganov/llama.cpp/pull/9074#issuecomment-2296799118 write better error messages in case of wrong types.

FYI: This ticket is free for others to approach

Possible Refactor Approaches

N/A

Contributor guide

Research direction
The issue requires improving type checking in GGUFWriter::add key value. Review the discussion at https://github.com/ggerganov/llama.cpp/pull/9074#issuecomment 2296799118 for context on desired error messages. The files to modify are likely in the gguf writer implementation, possibly in gguf writer.cpp or similar. Implement better type validation and error messages for mismatched types.
Tech stack
cpp
Domain
backendtooling
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++ basicsfamiliarity with llama.cppunderstanding of GGUF format
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70