ggml-org/llama.cpp

Llava functions compiled as extern "C" throw exceptions

Closed

#7,073 opened on May 4, 2024

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)C++ (21,764 forks)batch import
buggood first issue

Repository metrics

Stars
 (124,134 stars)
PR merge metrics
 (Avg merge 6d 8h) (389 merged PRs in 30d)

Description

Basically this: llama.cpp\examples\llava\clip.cpp(1277,13): warning : 'clip_model_load' has a non-throwing exception specification but can still throw [-Wexceptions] llama.cpp\examples\llava\clip.cpp(2075,5): warning : 'clip_n_mmproj_embd' has a non-throwing exception specification but can still throw [-Wexceptions]

As these are library exported functions and wrapped in extern "C", they should not allow exceptions to cross the boundary. C language has no idea what to do with them.

Compiled with clang-cl in windows.

Contributor guide

Research direction
The issue is in clip.cpp at lines 1277 and 2075, where functions declared with extern "C" (clip model load and clip n mmproj embd) have non throwing exception specifications but can still throw exceptions. To fix, wrap the function bodies in try catch blocks that return error indicators (e.g., 1 or nullptr) instead of allowing exceptions to propagate. Examine the existing error handling pattern in the file and ensure all externally visible functions follow this rule. No linked PRs or assignees exist yet.
Tech stack
cppc
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C++ exception handlingextern "C" linkage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40