ggml-org/llama.cpp

llama : integer type consistency in `llama.h`

Open

#4,574 opened on Dec 21, 2023

View on GitHub
 (3 comments) (4 reactions) (0 assignees)C++ (18,202 forks)batch import
enhancementgood first issuerefactoringroadmap

Repository metrics

Stars
 (110,169 stars)
PR merge metrics
 (Avg merge 6d 8h) (389 merged PRs in 30d)

Description

Feature Description

llama.h should prefer to use sized (always) + signed (mostly) integers.

Motivation

The integer types in llama.h right now are.

Count Type
33 int
10 int32_t
24 uint32_t
2 int64_t
2 uint64_t

In #4540 there was a discussion around preferences for integer types on new methods.

Avoiding int makes cross platform code simpler at essentially no cost. Signed makes arithmetic simpler at the cost of some bits if you need something large.

Possible Implementation

  1. Change all int's to int32_t
  2. As code changes try to prefer signed integers.

We could also do some higher-impact things, but I'd take the lower-impact slower changes over a large find-and-replace.

Contributor guide

Research direction
Review `llama.h` to identify all `int` declarations and assess if they can be changed to `int32 t` or other sized signed integers, considering cross platform implications.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75