ggml-org/ggml

Unexpected behavior for GGML_MEAN

Open

#1,005 opened on Nov 2, 2024

View on GitHub
 (10 comments) (2 reactions) (0 assignees)C++ (1,646 forks)auto 404
good first issue

Repository metrics

Stars
 (14,741 stars)
PR merge metrics
 (Avg merge 33m) (12 merged PRs in 30d)

Description

The usual behavior for the "mean" operation in numerical frameworks is a reduction of a tensor to a single value. However, in GGML this operation instead calculates the mean per row. This is I think unexpected behavior and the naming is also inconsistent with GGML_SUM (per tensor) and GGML_SUM_ROWS (per row).

Contributor guide

Research direction
Examine the implementation of GGML MEAN, GGML SUM, and GGML SUM ROWS to understand the discrepancy and discuss potential fixes with the community.
Tech stack
cpp
Domain
backendmachine learning
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65