gfx-rs/wgpu

[naga] `Arena` could use a `take` method

Open

#6,509 opened on Nov 9, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (9,290 stars) (703 forks)batch import
good first issuekind: refactornaga

Description

There are a few places in Naga where we actually clone an Arena, in situations where a take would be better. For example, naga::front::wgsl::lower::Lowerer::lower clones the diagnostic filters array.

Contributor guide

Tech stack
rust
Domain
backendperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rustknowledge of Arena pattern
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the Arena type in Naga to determine if a take method can be added. Look at the usage in naga::front::wgsl::lower::Lowerer::lower and other places where Arena is cloned. Implement a take method that removes and returns data, and replace clones with take calls. Ensure all tests pass.