gfx-rs/wgpu

Enable `clippy::tests_outside_test_module` lint

Open

#6,106 opened on Aug 12, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (9,290 stars) (703 forks)batch import
area: infrastructuregood first issuetype: enhancement

Description

There's a whole bunch of tests that aren't in test modules. This should be solved once and for all using this clippy lint https://rust-lang.github.io/rust-clippy/master/index.html#/tests_outside_test_module

Not doing so means that the tests will be unnecessarily compiled as part of non test builds

Contributor guide

Tech stack
rust
Domain
testingdeveloper experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust basicscargo clippy familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Enable the `clippy::tests outside test module` lint in the workspace's clippy configuration (likely in `Cargo.toml` or `.cargo/config.toml`). Then run `cargo clippy all targets` to identify all test functions currently outside a `#[cfg(test)]` module. Move each identified test into an appropriate test module within its file. Ensure tests still pass with `cargo test`. No linked PRs or maintainer comments indicate blockers. The issue is open with no assignees, so a newcomer can claim it.
Enable `clippy::tests_outside_test_module` lint · gfx-rs/wgpu#6106 | Good First Issue