gfx-rs/wgpu

Enable `clippy::tests_outside_test_module` lint

Open

#6,106 opened on Aug 12, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (703 forks)batch import
area: infrastructuregood first issuetype: enhancement

Repository metrics

Stars
 (9,290 stars)
PR merge metrics
 (Avg merge 12d 4h) (117 merged PRs in 30d)

Description

There's a whole bunch of tests that aren't in test modules. This should be solved once and for all using this clippy lint https://rust-lang.github.io/rust-clippy/master/index.html#/tests_outside_test_module

Not doing so means that the tests will be unnecessarily compiled as part of non test builds

Contributor guide

Research direction
Enable the clippy lint `clippy::tests outside test module` and move tests that are outside test modules into test modules. This will reduce unnecessary compilation in non test builds.
Tech stack
rust
Domain
testing
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75