gfx-rs/wgpu

Test Buffer to Buffer and Buffer to/from Image Copies with Problematic Usages

Open

#3,161 opened on Nov 1, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Rust (9,290 stars) (703 forks)batch import
area: testsbackend: glesgood first issuehelp requiredtype: enhancement

Description

WebGL has numerous issues with Index buffers being funky to use correctly, which necessitates various workarounds and nuance in the code dealing with copies. This is exemplified by #3157 but there is additional nuance.

https://github.com/gfx-rs/wgpu/blob/master/wgpu-hal/src/gles/queue.rs#L268-338 is the link to the buffer-to-buffer implementation.

Getting this working is also predicated on having our tests run in the browser.

Contributor guide

Tech stack
rust
Domain
backendtesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
RustWebGLwgpu internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the buffer copy issues in wgpu's GLES backend, focusing on the code at wgpu hal/src/gles/queue.rs lines 268-338. Review linked issue #3157 for context on WebGL index buffer workarounds. The solution requires fixing the buffer to buffer and buffer to/from image copies to handle problematic usages, which may involve implementing workarounds similar to those in #3157. Additionally, the tests must be runnable in a browser environment, so understanding the test infrastructure is necessary.