gfx-rs/wgpu

WGPU_TRACE file from Firefox Nightly is missing final close-bracket

Open

#1,620 opened on Jul 9, 2021

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Rust (9,290 stars) (703 forks)batch import
good first issuehelp requiredtype: bug

Description

Description When running a wasm binary on Firefox Nightly with tracing enabled (as per this, the generated trace.ron file is missing a final ]. As a result, the player fails with an "unexpected EOF" error. Manually adding the ] allows the player to work.

Compared to tracing the same program compiled natively, it's also missing various DestroyBindGroup/DestroyBuffer etc. calls, which might be related to the final ] being missing.

Platform MacOS 11.4, wgpu latest (e27fbb821bb3397069d0a82ef8da8e151feb0647), Firefox Nightly 2021-07-07.

Contributor guide

Tech stack
rustwasm
Domain
toolingtesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Rustwgpu tracing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the trace file generation code in wgpu to ensure the closing bracket is written. Compare the native trace generation with the wasm path. Look at the Player's RON parsing. Possibly related to missing Destroy calls; check if they are being emitted and not flushed before EOF.