getzola/zola

Broken shortcodes on 0.19

Open

#2,565 opened on Jul 3, 2024

View on GitHub
 (18 comments) (1 reaction) (0 assignees)Rust (15,349 stars) (1,046 forks)batch import
buggood first issuehelp wanted

Description

I had a shortcode called email which contained my email address for reasons, and used it as such

<a name="contact-me" href="mailto:{{ email() }}">{{ email() }}</a>

This used to work but I have since upgraded to 0.19.1 and it simply outputs @@ZOLA_SC_PLACEHOLDER@@

I had to move the entire tag into the shortcode for it to work again, but this smells like a bug and a regression to me.

Contributor guide

Tech stack
rust
Domain
backendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustZola shortcode system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the shortcode rendering logic in Zola's source code, specifically looking at how placeholders like @@ZOLA SC PLACEHOLDER@@ are generated and resolved. Check the git history for changes between versions 0.18 and 0.19 that might have introduced this regression. Focus on the shortcode processing modules, possibly in `components/shortcode` or `components/templates`. The fix should ensure that shortcode output is correctly substituted.
Broken shortcodes on 0.19 · getzola/zola#2565 | Good First Issue