Symlink containment check breaks on Python 3.8 runtimes
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
Research direction
Start in sk/agents-md/skills/skill-scanner/scripts/scan_skill.py and inspect the symlink containment check using target.is_relative_to(). Reproduce the scan under Python 3.8 with a workspace containing a symlink case, then verify that supported legacy runtimes complete the scan without an AttributeError or aborting before results are produced.
Written by the indexing model from the issue text.
Description
Affected file: sk/agents-md/skills/skill-scanner/scripts/scan_skill.py
What I hit
I ran the scanner in a Python 3.8 setup and it crashed before producing scan results.
I’m thinking this is due to:
is_internal = target.is_relative_to(skill_dir.resolve())
which is not available on older interpreter versions.
Repro
- Execute the script under Python 3.8.
- Scan a workspace containing a symlink case.
- The script exits with
AttributeError.
Expected
The scanner should run on legacy supported versions without crashing on path checks.
Actual
One API call can fail and abort the scan flow.
Suggested fix
Use .resolve() + relative_to with exception handling for Python compatibility.
- Dominant language
- Python
- Stars
- 1k
- Forks
- 52
- Avg merge
- 7h 49m
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from getsentry/skills
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
-
Difficulty 4/5 3-5 days Newbie friendliness 58/100
-
Difficulty 3/5 1-2 days Newbie friendliness 20/100
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
All issues in getsentry/skills
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100