node-integration-tests: drop static pins from non-tracing suites
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 74/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- node.js, typescript
- Domain
- testing-qa
Research direction
Start with the parent issue's porting recipe, then search the listed node-integration-tests suite directories for traceLifecycle: 'static'. Remove the pin from the non-tracing suites named under “pin removal only”; leave the seven assertion-rewrite groups for separate work. Done means those suites no longer carry the unnecessary static pin while the listed envelope-asserting suites remain unchanged.
Written by the indexing model from the issue text.
Description
Follow the porting recipe in the parent issue.
Largest group by file count and the smallest by effort. Roughly 90 suite directories carry the traceLifecycle: 'static' pin without ever asserting on a transaction envelope, so the pin just needs to go.
Suites (pin removal only)
public-api/*except the span surface dirs owned by the trace semantics sub-issue:addBreadcrumb,captureException,captureMessage,configureScope,LocalVariables,logger,metrics,OnUncaughtException,setContext,setExtra,setExtras,setTag,setTags,setUser,withMonitor,withScopesessions,cron/*,client-reports/periodic-send- Logging:
pino,winston,consola,integrations/console/filter - Runtime:
anr,system-error,thread-blocked-native,child-process,modules,esm/*,contextLines/*,breadcrumbs/process-thread,node-runtime-metrics,bun-runtime-metrics vercel/sigterm-flush
Suites that still need an assertion rewrite
These 7 do assert on transaction envelopes:
public-api/onUnhandledRejectionIntegrationclient-reports/drop-reasons/*(4 dirs)featureFlags/featureFlagsIntegration/onSpanandfeatureFlags/growthbook/onSpanfs-instrumentationaws-serverless/aws-integration(foldaws-serverless/aws-integration-streamedback into it)
Splitting this issue into a mechanical pin-removal PR and a smaller rewrite PR is fine.
- Dominant language
- TypeScript
- Stars
- 8.7k
- Forks
- 1.9k
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 543
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from getsentry/sentry-javascript
-
Browser Waiting for: Product Owner
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
getsentry/sentry-javascript#24577 · 1 comment ·
-
Task
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
getsentry/sentry-javascript#24558 · 1 comment ·
-
Task
Difficulty 1/5 Under an hour Newbie friendliness 90/100
getsentry/sentry-javascript#24557 · 1 comment ·
-
Task
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
getsentry/sentry-javascript#24556 · 1 comment ·
-
Task
Difficulty 1/5 1-3 hours Newbie friendliness 90/100
getsentry/sentry-javascript#24555 · 1 comment ·
All issues in getsentry/sentry-javascript
Similar issues
-
clawsweeper:linked-pr-open clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:message-loss issue-rating: 🦞 diamond lobster maturity:stable P2
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#616 ·
-
ZCode 3.14.3 に対応する Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
supermomonga/zcode-acp#24 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
growthbook/growthbook#7100 ·
-
triage
Difficulty 1/5 1-3 hours Newbie friendliness 88/100