getredash/redash

Query editor: format query feature breaks syntax of Postgres JSON operator

Open

#5644 opened on Nov 8, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (24,845 stars) (4,236 forks)batch import
help wanted

Description

Issue Summary

Query editor: format query feature breaks syntax of Postgres JSON operator

Steps to Reproduce

  1. WHERE keywords @> '[{"keyword":{"id":12345}}]'
  2. Valid according to: https://www.postgresql.org/docs/12/functions-json.html
  3. Gets formatted as keywords @ > '[{"keyword":{"id":12345}}]'
  4. This is invalid syntax because the @ and > have become separated

Technical details:

  • Redash Version: 10.0.0-beta (92e5d78d)

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Redash query editor
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the query formatting logic in the Redash frontend. Look for a SQL formatter function that tokenizes operators. The issue is that `@>` is being split into two tokens. Check if there is a list of operators that needs to include `@>` as a single token. Relevant code is likely in the client directory, possibly in a file like 'QueryEditor.jsx'. Review any existing tests for the formatter.